Added Object._cid getter, optimized it. Added to (some) classes a static final _clCid. Use those to…

runtime/lib/object.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/stack_frame.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, enable_type_checks);
 
 
+DEFINE_NATIVE_ENTRY(Object_cid, 1) {
+  const Instance& instance = Instance::CheckedHandle(arguments->NativeArgAt(0));

[siva, 2013/05/13 20:38:00]

GET_NONE_NULL_NATIVE_ARGUMENT(Instance, instance, arguments->NativeArgAt(0));

If the object is NULL I don't think we will get the correct cid.

[Ivan Posva, 2013/05/13 22:12:37]

Null is a valid receiver for the _cid method. So I do think this code here is
correct.

[srdjan, 2013/05/14 17:46:31]

What Ivan said.

+  const Class& cls = Class::Handle(instance.clazz());
+  return Smi::New(cls.id());
+}
+
+
 DEFINE_NATIVE_ENTRY(Object_toString, 1) {
   const Instance& instance = Instance::CheckedHandle(arguments->NativeArgAt(0));
   const char* c_str = instance.ToCString();
   return String::New(c_str);
 }
 
 
 DEFINE_NATIVE_ENTRY(Object_noSuchMethod, 6) {
   const Instance& instance = Instance::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Bool, is_method, arguments->NativeArgAt(1));
@@ skipping 138 matching lines @@
 }
 
 
 DEFINE_NATIVE_ENTRY(AbstractType_toString, 1) {
   const AbstractType& type =
       AbstractType::CheckedHandle(arguments->NativeArgAt(0));
   return type.UserVisibleName();
 }
 
 }  // namespace dart