Added Object._cid getter, optimized it. Added to (some) classes a static final _clCid. Use those to…

runtime/lib/array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 // TODO(srdjan): Use shared array implementation.
 class _ObjectArray<E> implements List<E> {
+  static final int _clCid = (new List(0))._cid;

[siva, 2013/05/13 20:38:00]

clCid seems redundant 'class class id'
maybe _classId

[Ivan Posva, 2013/05/13 22:12:37]

I really like the suggestion of _classId. Also please allocate a _ObjectArray
here instead of relying on the List constructor doing the right thing.

[srdjan, 2013/05/14 17:46:31]

Done.

[srdjan, 2013/05/14 17:46:31]

Done.

 
   factory _ObjectArray(length) native "ObjectArray_allocate";
 
   E operator [](int index) native "ObjectArray_getIndexed";
 
   void operator []=(int index, E value) native "ObjectArray_setIndexed";
 
   String toString() {
     return ToString.iterableToString(this);
   }
@@ skipping 250 matching lines @@
 
 
 // This is essentially the same class as _ObjectArray, but it does not
 // permit any modification of array elements from Dart code. We use
 // this class for arrays constructed from Dart array literals.
 // TODO(hausner): We should consider the trade-offs between two
 // classes (and inline cache misses) versus a field in the native
 // implementation (checks when modifying). We should keep watching
 // the inline cache misses.
 class _ImmutableArray<E> implements List<E> {
+  static final int _clCid = (const [])._cid;
 
   factory _ImmutableArray._uninstantiable() {
     throw new UnsupportedError(
         "ImmutableArray can only be allocated by the VM");
   }
 
   E operator [](int index) native "ObjectArray_getIndexed";
 
   void operator []=(int index, E value) {
     throw new UnsupportedError(
@@ skipping 255 matching lines @@
     }
     _position = _length;
     _current = null;
     return false;
   }
 
   E get current {
     return _current;
   }
 }