Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 147023005: Don't propagate information through phis in loop headers. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
Igor Sheludko, titzer
CC:
v8-dev
Visibility:
Public.

Description

Don't propagate information through phis in loop headers. To properly do this, we'd have to iterate over CompareMaps (and their bodies) handling phis, until we have learned enough to decide which paths can be taken. For now, just disable learning from phis in loop headers. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19341

Patch Set 1 #

Patch Set 2 : Replace print with assertEquals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/hydrogen-check-elimination.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-check-eliminate-loop-phis.js View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-12 18:28:58 UTC) #1
Igor Sheludko
lgtm
6 years, 10 months ago (2014-02-12 18:30:17 UTC) #2
Toon Verwaest
6 years, 10 months ago (2014-02-12 18:30:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19341 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698