Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 14702006: Merge 198700 "Changed the item click behavior of auto complete l..." (Closed)

Created:
7 years, 7 months ago by yoshiki
Modified:
7 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Merge 198700 "Changed the item click behavior of auto complete l..." On behalf of hirono@chromium.org. > Changed the item click behavior of auto complete list. > > Originally, when the item of auto complete list is clicked, the default task of > selected item is executed. This CL handles the cases of other dialog types > except FULL_PAGE. In this cases, when the item of auto complete list is clicked, > the file manager should be closed like that its OK button is clicked. > > BUG=237549 > TEST=Open file manager as a modal dialog (by Ctrl+O, Ctrl + S), search drive items by using auto complete list and click a result item > > Review URL: https://chromiumcodereview.appspot.com/14797006 TBR=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yoshiki
7 years, 7 months ago (2013-05-13 07:36:30 UTC) #1
yoshiki
7 years, 7 months ago (2013-05-13 07:36:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r199683.

Powered by Google App Engine
This is Rietveld 408576698