Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: src/js/regexp.js

Issue 1470193002: Array/TypedArray/ArrayBuffer method subclassing and @@species (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/arraybuffer.js ('k') | src/js/runtime.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/regexp.js
diff --git a/src/js/regexp.js b/src/js/regexp.js
index a163952451f082ea50e12678a7a94fffa3e4052e..5d291245c7eed398e160aee4fa799590e8404d74 100644
--- a/src/js/regexp.js
+++ b/src/js/regexp.js
@@ -300,6 +300,10 @@ function RegExpSplit(string, limit) {
throw MakeTypeError(kIncompatibleMethodReceiver,
"RegExp.prototype.@@split", this);
}
+
+ // TODO(yangguo): Clone the RegExp using SpeciesConstructor
+ // to change the flags to turn 'y' on.
+
var separator = this;
var subject = TO_STRING(string);
« no previous file with comments | « src/js/arraybuffer.js ('k') | src/js/runtime.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698