Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1470173003: PPC: Refine "Adds the possibility of setting a Code object as the callback of a FunctionTemplate." (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Refine "Adds the possibility of setting a Code object as the callback of a FunctionTemplate." R=epertoso@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/67c036c16bc6bb4df98c96064059da52b6afd996 Cr-Commit-Position: refs/heads/master@{#32228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M src/ppc/builtins-ppc.cc View 4 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years ago (2015-11-24 19:17:20 UTC) #1
michael_dawson
On 2015/11/24 19:17:20, mtbrandyberry wrote: lgtm
5 years ago (2015-11-24 19:41:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470173003/1
5 years ago (2015-11-24 19:50:18 UTC) #4
michael_dawson
On 2015/11/24 19:50:18, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years ago (2015-11-24 20:01:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 20:28:38 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 20:29:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67c036c16bc6bb4df98c96064059da52b6afd996
Cr-Commit-Position: refs/heads/master@{#32228}

Powered by Google App Engine
This is Rietveld 408576698