Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 1470153004: Autoplay experiment metric fixes and additions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ...because tests. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
index 05c1fcd9f311778302f33b28076ea5108a3872b1..8f5e5e724b65aa16720ac3bdd55db79d41d2cde7 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
@@ -284,6 +284,8 @@ protected:
DisplayMode getDisplayMode() const { return m_displayMode; }
virtual void setDisplayMode(DisplayMode mode) { m_displayMode = mode; }
+ void recordAutoplayMetric(AutoplayMetrics);
+
private:
void resetMediaPlayerAndMediaSource();
@@ -390,14 +392,6 @@ private:
// This does not change the buffering strategy.
void pauseInternal();
- // If we are about to enter a paused state, call this to record
- // autoplay metrics. If we were already in a stopped state, then
- // this does nothing.
- void recordMetricsIfPausing();
- // Could stopping at this point be considered a bailout of playback?
- // (as in, "The user really didn't want to play this").
- bool isBailout() const;
- void autoplayMediaEncountered();
void allowVideoRendering();
void updateVolume();
@@ -429,8 +423,6 @@ private:
void setAllowHiddenVolumeControls(bool);
- void recordAutoplayMetric(AutoplayMetrics);
-
WebMediaPlayer::CORSMode corsMode() const;
// Returns the "direction of playback" value as specified in the HTML5 spec.
@@ -450,8 +442,11 @@ private:
// Return true if and only if we require a user gesture before letting
// the media play.
bool isUserGestureRequiredForPlay() const;
+
+ // If the user gesture is required, then this will remove it. Note that
+ // one should not generally call this method directly; use the one on
+ // m_helper and give it a reason.
void removeUserGestureRequirement();
- void setInitialPlayWithoutUserGestures(bool);
void setNetworkState(NetworkState);
@@ -565,8 +560,6 @@ private:
bool m_remoteRoutesAvailable : 1;
bool m_playingRemotely : 1;
bool m_isFinalizing : 1;
- bool m_initialPlayWithoutUserGesture : 1;
- bool m_autoplayMediaCounted : 1;
// Whether this element is in overlay fullscreen mode.
bool m_inOverlayFullscreenVideo : 1;
@@ -636,12 +629,15 @@ private:
AudioSourceProviderImpl m_audioSourceProvider;
+ class AutoplayHelperClientImpl;
+
friend class Internals;
friend class TrackDisplayUpdateScope;
friend class AutoplayExperimentHelper;
friend class MediaControlsTest;
- AutoplayExperimentHelper m_autoplayHelper;
+ OwnPtrWillBeMember<AutoplayExperimentHelper::Client> m_autoplayHelperClient;
+ OwnPtrWillBeMember<AutoplayExperimentHelper> m_autoplayHelper;
WebRemotePlaybackClient* m_remotePlaybackClient;

Powered by Google App Engine
This is Rietveld 408576698