Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h

Issue 1470153004: Autoplay experiment metric fixes and additions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cl feedback. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
diff --git a/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
index a35406017692312b1c2aab08fc8c726e0ca14326..6d69a56deeb700e5e1df2f047edf7fd101e85100 100644
--- a/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
+++ b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
@@ -62,6 +62,29 @@ enum AutoplayMetrics {
AnyPlaybackPaused = 12,
// Some playback, whether user initiated or not, bailed out early.
AnyPlaybackBailout = 13,
+ // Some playback, whether user initiated or not, played to completion.
+ AnyPlaybackComplete = 14,
+
+ // Number of audio elements detected.
philipj_slow 2015/11/26 15:30:56 Clarify that this is only elements that reached th
liberato (no reviews please) 2015/12/02 00:58:08 Done.
+ AnyAudioElement = 15,
+ // Numer of video elements detected.
+ AnyVideoElement = 16,
+
+ // User gesture was bypassed, and playback started, and media played to
+ // completion without a user-initiated pause.
+ AutoplayComplete = 17,
+
+ // Autoplay started after the gesture requirement was removed by a
+ // user gesture load().
+ GesturelessPlaybackEnabledByLoad = 18,
+
+ // Gestureless playback started after the gesture requirement was removed
+ // because src is media stream.
+ GesturelessPlaybackEnabledByStream = 19,
+
+ // Gestureless playback was started, but it is unknown why a user gesture
+ // was not required. This includes the case where none is ever required.
+ GesturelessPlaybackUnknownReason = 20,
// This enum value must be last.
NumberOfAutoplayMetrics,
@@ -137,7 +160,7 @@ private:
// Configure internal state to record that the autoplay experiment is
// going to start playback. This doesn't actually start playback, since
// there are several different cases.
- void prepareToPlay(AutoplayMetrics);
+ void prepareToAutoplay(AutoplayMetrics);
// Process a timer for checking visibility.
void viewportTimerFired(Timer<AutoplayExperimentHelper>*);

Powered by Google App Engine
This is Rietveld 408576698