Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h

Issue 1470153004: Autoplay experiment metric fixes and additions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added histograms.xml . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
diff --git a/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
index a35406017692312b1c2aab08fc8c726e0ca14326..923f9eaacc14cf73e2069f988812588011b36870 100644
--- a/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
+++ b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
@@ -62,6 +62,33 @@ enum AutoplayMetrics {
AnyPlaybackPaused = 12,
// Some playback, whether user initiated or not, bailed out early.
AnyPlaybackBailout = 13,
+ // Some playback, whether user initiated or not, played to completion.
+ AnyPlaybackComplete = 14,
+
+ // Number of media elements detected.
+ AnyMediaElement = 15,
+ // Numer of video elements detected.
+ AnyVideoElement = 16,
+
+ // User gesture was bypassed,and playback started, and media played to
philipj_slow 2015/11/25 14:03:41 space before comma
liberato (no reviews please) 2015/11/25 18:58:54 Done.
+ // completion without a user-supplied pause.
philipj_slow 2015/11/25 14:03:41 user-initiated maybe?
liberato (no reviews please) 2015/11/25 18:58:54 Done.
+ AutoplayComplete = 17,
+
+ // The initial playback started with a user gesture being processed by the
+ // element at or before.
philipj_slow 2015/11/25 14:03:41 at or before... what? :)
liberato (no reviews please) 2015/11/25 18:58:54 Done.
+ InitialPlayWithUserGesture = 18,
+
+ // The initial playback started while a user gesture was being processed.
+ InitialPlayDuringUserGesture = 19,
+
+ // The initial playback started while no user gesture was being processed,
+ // though one might have been processed earlier to remove any gesture
+ // requirement (e.g., during load).
+ InitialPlayNotDuringUserGesture = 20,
+
+ // The initial playback started without any user gesture being processed
+ // by the element now or at any point prior to this.
+ InitialPlayWithoutUserGesture = 21,
// This enum value must be last.
NumberOfAutoplayMetrics,
@@ -137,7 +164,7 @@ private:
// Configure internal state to record that the autoplay experiment is
// going to start playback. This doesn't actually start playback, since
// there are several different cases.
- void prepareToPlay(AutoplayMetrics);
+ void prepareToAutoplay(AutoplayMetrics);
// Process a timer for checking visibility.
void viewportTimerFired(Timer<AutoplayExperimentHelper>*);

Powered by Google App Engine
This is Rietveld 408576698