Log some very basic timers in WebUI tests using PolymerTest

Log some very basic timers in WebUI tests using PolymerTest

This introduces some very simple timers as a starting point for
benchmarking WebUI pages.

BUG=560432
Committed: https://crrev.com/ee04f7688948ac3f8070a72dd554083a768f9a2f
Cr-Commit-Position: refs/heads/master@{#361407}

[stevenjb, 2015-11-23 23:09:18]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org, michaelpg@chromium.org

[Dan Beam, 2015-11-23 23:10:52]

https://codereview.chromium.org/1470133002/diff/1/chrome/test/data/webui/poly...
File chrome/test/data/webui/polymer_browser_test_base.js (right):

https://codereview.chromium.org/1470133002/diff/1/chrome/test/data/webui/poly...
chrome/test/data/webui/polymer_browser_test_base.js:125:
testing.Test.prototype.tearDown.call(this);
nit: can we use console.time() + console.timeEnd()?

[stevenjb, 2015-11-23 23:24:41]

https://codereview.chromium.org/1470133002/diff/1/chrome/test/data/webui/poly...
File chrome/test/data/webui/polymer_browser_test_base.js (right):

https://codereview.chromium.org/1470133002/diff/1/chrome/test/data/webui/poly...
chrome/test/data/webui/polymer_browser_test_base.js:125:
testing.Test.prototype.tearDown.call(this);
On 2015/11/23 23:10:51, Dan Beam wrote:
> nit: can we use console.time() + console.timeEnd()?

I was thinking that later we might want to do something in individual tests that
log something like 'Time to basic page ready', etc.

Also, I prefer to log all of the times at the end. With console.time I would
need to log, e.g. the page load time before running the tests, making that
output harder to find.

[Dan Beam, 2015-11-23 23:29:56]

lgtm but maybe consider doing this in testing.Test instead?  non-polymer UIs
also have flakiness/timeout issues, btw

[stevenjb, 2015-11-23 23:32:11]

On 2015/11/23 23:29:56, Dan Beam wrote:
> lgtm but maybe consider doing this in testing.Test instead?  non-polymer UIs
> also have flakiness/timeout issues, btw

Let's start here and once we're happy with what we've got, and have integrated
it with telemetry or other testing framework, we can move it up to testing.Test.
I don't want to just add a bunch of log spam that nobody is looking at.

[michaelpg, 2015-11-24 00:10:02]

lgtm

[stevenjb, 2015-11-24 00:18:21]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2015-11-24 00:20:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470133002/1

[commit-bot: I haz the power, 2015-11-24 03:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:41:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2015-11-24 18:35:13]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2015-11-24 18:36:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470133002/1

[commit-bot: I haz the power, 2015-11-24 19:07:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-24 19:07:57]

Patchset 1 (id:??) landed as
https://crrev.com/ee04f7688948ac3f8070a72dd554083a768f9a2f
Cr-Commit-Position: refs/heads/master@{#361407}

[michaelpg, 2015-11-24 23:26:19]

https://codereview.chromium.org/1470133002/diff/1/chrome/test/data/webui/poly...
File chrome/test/data/webui/polymer_browser_test_base.js (right):

https://codereview.chromium.org/1470133002/diff/1/chrome/test/data/webui/poly...
chrome/test/data/webui/polymer_browser_test_base.js:120: console.log('Page load
time: ' + delta + " ms");
Turns out floats are really annoying to read...

Could we round delta? or if we want to keep decimal places for some reason,
Math.round(delta * 100) / 100

[stevenjb, 2015-11-24 23:28:40]

Sure, I can do that in a follow-up.


On Tue, Nov 24, 2015 at 4:26 PM, <michaelpg@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1470133002/diff/1/chrome/test/data/webui/poly...
> File chrome/test/data/webui/polymer_browser_test_base.js (right):
>
>
>
https://codereview.chromium.org/1470133002/diff/1/chrome/test/data/webui/poly...
> chrome/test/data/webui/polymer_browser_test_base.js:120:
> console.log('Page load time: ' + delta + " ms");
> Turns out floats are really annoying to read...
>
> Could we round delta? or if we want to keep decimal places for some
> reason, Math.round(delta * 100) / 100
>
> https://codereview.chromium.org/1470133002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.