Issue 14701004: [Sync FileSystem] Implement directory supported RESOLVE_TO_LOCAL to LocalSync.

Issue 14701004: [Sync FileSystem] Implement directory supported RESOLVE_TO_LOCAL to LocalSync. (Closed)

Created:
7 years, 7 months ago by tzik

Modified:
7 years, 7 months ago

Reviewers:
kinuko, nhiroki

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync FileSystem] Implement directory supported RESOLVE_TO_LOCAL to LocalSync. BUG=161442 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197833

Patch Set 3 : handle error, DCHECK fix #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -5 lines)			Patch
	M	chrome/browser/sync_file_system/drive_file_sync_service.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/sync_file_system/drive_file_sync_service.cc	View	1 2	2 chunks	+42 lines, -5 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

nhiroki

https://codereview.chromium.org/14701004/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (right): https://codereview.chromium.org/14701004/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode1140 chrome/browser/sync_file_system/drive_file_sync_service.cc:1140: DCHECK_NE(SYNC_FILE_TYPE_UNKNOWN, param->local_metadata.file_type); What happen if delete operation failed? https://codereview.chromium.org/14701004/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode1152 ...

7 years, 7 months ago (2013-05-02 03:32:01 UTC) #2

tzik

Updated https://codereview.chromium.org/14701004/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (right): https://codereview.chromium.org/14701004/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode1140 chrome/browser/sync_file_system/drive_file_sync_service.cc:1140: DCHECK_NE(SYNC_FILE_TYPE_UNKNOWN, param->local_metadata.file_type); On 2013/05/02 03:32:01, nhiroki wrote: > ...

7 years, 7 months ago (2013-05-02 03:52:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/14701004/8001

7 years, 7 months ago (2013-05-02 04:25:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/14701004/8001

7 years, 7 months ago (2013-05-02 05:11:25 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/14701004/8001

7 years, 7 months ago (2013-05-02 05:36:42 UTC) #7

Message was sent while issue was closed.

Change committed as 197833

Expand Messages | Collapse Messages