[CacheStorage] Keep caches alive for 30 seconds after opening

[CacheStorage] Keep caches alive for 30 seconds after opening

Common operations, like CacheStorage.match, quickly open and close caches. Opening
the cache is expensive and cache reads often come in succession (e.g.,
fetching each resource for a page).

This CL keeps a reference to each freshly opened cache for 30 seconds so that it can
be used again without incurring the overhead of opening.

BUG=558427
Committed: https://crrev.com/aff3e8a028bd31ba8f2d65f22c706a1dfbbf9ca6
Cr-Commit-Position: refs/heads/master@{#361645}

[jkarlin, 2015-11-24 19:15:29]

jkarlin@chromium.org changed reviewers:
+ nhiroki@chromium.org

[jkarlin, 2015-11-24 19:15:30]

nhiroki@ PTAL, thank you!

[jkarlin, 2015-11-24 19:16:41]

Description was changed from

==========
[CacheStorage] Keep caches alive for 30 seconds after opening

Common operations like CacheStorage.match open caches, read entries,
and immediately close them since they're no longer referenced. Opening
the cache is expensive and cache reads often come in succession (e.g.,
fetching each resource for a page).

This CL keeps a reference to each freshly opened cache for 30 seconds
so that it doesn't close before it's likely to be used again.

BUG=558427
==========

to

==========
[CacheStorage] Keep caches alive for 30 seconds after opening

Common operations, like CacheStorage.match, quickly open and close caches.
Opening
the cache is expensive and cache reads often come in succession (e.g.,
fetching each resource for a page).

This CL keeps a reference to each freshly opened cache for 30 seconds so that it
can
be used again without incurring the overhead of opening.

BUG=558427
==========

[nhiroki, 2015-11-25 06:21:32]

LGTM after failing tests are fixed

https://codereview.chromium.org/1470073003/diff/40001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_unittest.cc (right):

https://codereview.chromium.org/1470073003/diff/40001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_unittest.cc:46: bool
isPreservingCache(const CacheStorageCache* cache) {
nit: s/is/Is/

[jkarlin, 2015-11-25 13:03:46]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2015-11-25 13:03:47]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1470073003/#ps80001
(title: "Address comments from PS3")

[jkarlin, 2015-11-25 13:04:17]

Thanks!

https://codereview.chromium.org/1470073003/diff/40001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_unittest.cc (right):

https://codereview.chromium.org/1470073003/diff/40001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_unittest.cc:46: bool
isPreservingCache(const CacheStorageCache* cache) {
On 2015/11/25 06:21:32, nhiroki wrote:
> nit: s/is/Is/

Done.

[commit-bot: I haz the power, 2015-11-25 13:04:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470073003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470073003/80001

[commit-bot: I haz the power, 2015-11-25 14:10:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-25 14:11:33]

Patchset 5 (id:??) landed as
https://crrev.com/aff3e8a028bd31ba8f2d65f22c706a1dfbbf9ca6
Cr-Commit-Position: refs/heads/master@{#361645}