Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1470073002: Restart crashpad_handler on Mac if it exits unexpectedly (Closed)

Created:
5 years ago by Mark Mentovai
Modified:
5 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restart crashpad_handler on Mac if it exits unexpectedly This feature is only operative on OS X 10.10 and later, as directed by CrashpadClient::StartHandler(). This limitation is enforced because the handler restarter can cause the browser process to become an unreapable pseudo-zombie on earlier OS versions if it crashes while a handler restart is pending. Committed: https://crrev.com/2c777f1149c46c47eaa3307a38070c82eff93835 Cr-Commit-Position: refs/heads/master@{#361201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/crash/content/app/crashpad_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Mentovai
5 years ago (2015-11-23 21:43:38 UTC) #2
Robert Sesek
LGTM
5 years ago (2015-11-23 21:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470073002/1
5 years ago (2015-11-23 21:55:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 22:24:55 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-23 22:25:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c777f1149c46c47eaa3307a38070c82eff93835
Cr-Commit-Position: refs/heads/master@{#361201}

Powered by Google App Engine
This is Rietveld 408576698