Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Unified Diff: skia/ext/SkFontHost_fontconfig_impl.h

Issue 147005: Linux: fix fake italics for font's without italic variants. (Closed)
Patch Set: ... Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/SkFontHost_fontconfig_direct.cpp ('k') | skia/ext/SkFontHost_fontconfig_ipc.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/SkFontHost_fontconfig_impl.h
diff --git a/skia/ext/SkFontHost_fontconfig_impl.h b/skia/ext/SkFontHost_fontconfig_impl.h
index a59389193b6151dd66c03f3de6da9d5fea088bac..f3b4b411045c1a233b03186d3a772b53f022fefe 100644
--- a/skia/ext/SkFontHost_fontconfig_impl.h
+++ b/skia/ext/SkFontHost_fontconfig_impl.h
@@ -39,8 +39,8 @@ class FontConfigInterface {
* trying to match.
* @param family (optional) the family of the font that we are trying to
* match.
- * @param is_bold (optional, set to -1 to ignore)
- * @param is_italic (optional, set to -1 to ignore)
+ * @param is_bold (optional, set to NULL to ignore, in/out)
+ * @param is_italic (optional, set to NULL to ignore, in/out)
* @return true iff successful.
*/
virtual bool Match(
@@ -49,8 +49,8 @@ class FontConfigInterface {
bool fileid_valid,
unsigned fileid,
const std::string& family,
- int is_bold,
- int is_italic) = 0;
+ bool* is_bold,
+ bool* is_italic) = 0;
/** Open a font file given the fileid as returned by Match
*/
« no previous file with comments | « skia/ext/SkFontHost_fontconfig_direct.cpp ('k') | skia/ext/SkFontHost_fontconfig_ipc.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698