Issue 147004: Linux: fix crash reporting for zygote model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147004: Linux: fix crash reporting for zygote model (Closed)

Created:
11 years, 6 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: fix crash reporting for zygote model Crash reporting broke on Linux when we enabled the zygote model a couple of weeks ago. We can't just add "zygote" to the check for the process type because the crash signal fd is set at the same time and that will change when a renderer is forked from the zygote. This fixes it for now, but it will need to be redone when we enable sandboxing.

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -9 lines)			Patch
M	chrome/app/breakpad_linux.cc	View	1 chunk	+4 lines, -2 lines	1 comment	Download
M	chrome/app/chrome_dll_main.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/renderer/renderer_main.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

11 years, 6 months ago (2009-06-23 03:52:45 UTC) #2

otherwise looks good.

http://codereview.chromium.org/147004/diff/1/2
File chrome/app/breakpad_linux.cc (right):

http://codereview.chromium.org/147004/diff/1/2#newcode524
Line 524: process_type == switches::kZygoteProcess) {
Is this ever the case? When does a zygote process call InitCrashReporter?

Expand Messages | Collapse Messages