Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1469983002: Stack sampling profiler: fix off-by-one error on truncated stacks (Closed)

Created:
5 years, 1 month ago by Mike Wittman
Modified:
5 years, 1 month ago
Reviewers:
brucedawson
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stack sampling profiler: fix off-by-one error on truncated stacks Stacks that are truncated due to the Win32StackFrameUnwinder being unable to unwind are being reported with an extra frame. BUG=555770 Committed: https://crrev.com/c2259413238814894aadcbbe07c8e1a8c12b2413 Cr-Commit-Position: refs/heads/master@{#361230}

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M base/profiler/native_stack_sampler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/profiler/stack_sampling_profiler_unittest.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Mike Wittman
PTAL
5 years, 1 month ago (2015-11-23 17:38:29 UTC) #2
brucedawson
lgtm
5 years, 1 month ago (2015-11-23 20:41:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469983002/1
5 years, 1 month ago (2015-11-23 20:44:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133015)
5 years, 1 month ago (2015-11-23 22:20:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469983002/20001
5 years, 1 month ago (2015-11-23 23:30:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-24 01:02:51 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 01:03:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2259413238814894aadcbbe07c8e1a8c12b2413
Cr-Commit-Position: refs/heads/master@{#361230}

Powered by Google App Engine
This is Rietveld 408576698