build/android/play_services/update_test.py - Issue 1469913002: Cleanup gms update/preprocess scripts, roll android_tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/play_services/update_test.py

Issue 1469913002: Cleanup gms update/preprocess scripts, roll android_tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/play_services/update_test.py

diff --git a/build/android/play_services/update_test.py b/build/android/play_services/update_test.py

index b6898b6afae4c3b0ec6f0584b18010b4590573a4..fd6815405f7df482bb1dbcdd125463146d6e2e7c 100755

--- a/build/android/play_services/update_test.py

+++ b/build/android/play_services/update_test.py

@@ -301,7 +301,9 @@ class TestFunctions(unittest.TestCase):

if config_version:

_MakeDirs(os.path.dirname(self.paths.config_file))

with open(self.paths.config_file, 'w') as stream:

- stream.write('{"version_number":%d}\n' % config_version)

+ stream.write(('{"version_number":%d,'

+ '"version_xml_path": "res/values/version.xml"}'

+ '\n') % config_version)

if existing_license:

_MakeDirs(self.paths.gms_root)

« no previous file with comments | « build/android/play_services/update.py ('k') | build/android/play_services/utils.py » ('j') | no next file with comments »