build/android/play_services/config.json - Issue 1469913002: Cleanup gms update/preprocess scripts, roll android_tools

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/play_services/config.json

Issue 1469913002: Cleanup gms update/preprocess scripts, roll android_tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Roll android_tools Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "version_number": 8298000	2 "version_number": 8298000,

	3 "version_xml_path": "res/values/version.xml"
	jbudorick 2015/12/02 19:09:40 Should this file also have sdk_version, clients, a Should this file also have sdk_version, clients, and locale_whitelist? If not, how do those get added? dgn 2015/12/03 16:36:57 This is a bit weird because it's read/write file. Show quoted text On 2015/12/02 19:09:40, jbudorick wrote: > Should this file also have sdk_version, clients, and locale_whitelist? If not, > how do those get added? This is a bit weird because it's read/write file. Scripts can write it to update the version number when pushing a new gmscore update, which affects the download script People can write it to change the configuration of the update or preprocess script Upstream we have no use of the other arguments, since we don't do the preprocessing. That's why they are not included in this file. jbudorick 2015/12/10 14:16:31 So what happens if somewhat attempts to use one of Show quoted text On 2015/12/03 16:36:57, dgn wrote: > On 2015/12/02 19:09:40, jbudorick wrote: > > Should this file also have sdk_version, clients, and locale_whitelist? If not, > > how do those get added? > > This is a bit weird because it's read/write file. > Scripts can write it to update the version number when pushing a new gmscore > update, which affects the download script > People can write it to change the configuration of the update or preprocess > script > > Upstream we have no use of the other arguments, since we don't do the > preprocessing. That's why they are not included in this file. > So what happens if somewhat attempts to use one of these other fields via ConfigParser? dgn 2015/12/10 14:35:19 Currently it would raise a KeyError when requestin Show quoted text On 2015/12/10 14:16:31, jbudorick wrote: > On 2015/12/03 16:36:57, dgn wrote: > > On 2015/12/02 19:09:40, jbudorick wrote: > > > Should this file also have sdk_version, clients, and locale_whitelist? If > not, > > > how do those get added? > > > > This is a bit weird because it's read/write file. > > Scripts can write it to update the version number when pushing a new gmscore > > update, which affects the download script > > People can write it to change the configuration of the update or preprocess > > script > > > > Upstream we have no use of the other arguments, since we don't do the > > preprocessing. That's why they are not included in this file. > > > > So what happens if somewhat attempts to use one of these other fields via > ConfigParser? Currently it would raise a KeyError when requesting one of the missing fields, but since they are looked at lazily, when trying to read the field, it sounds okay to me as way to communicate the issue. Is it better to have placeholder values?
3 }	4 }

OLD	NEW

« no previous file with comments | « DEPS ('k') | build/android/play_services/preprocess.py » ('j') | build/android/play_services/preprocess.py » ('J')