Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(459)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: build/android/preprocess_google_play_services.config.json
Issue
1469913002
:
Cleanup gms update/preprocess scripts, roll android_tools (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments
Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
DEPS
build/android/play_services/config.json
build/android/play_services/preprocess.py
build/android/play_services/update.py
build/android/play_services/update_test.py
build/android/play_services/utils.py
build/android/preprocess_google_play_services.py
build/android/preprocess_google_play_services.config.json
build/android/pylib/utils/argparse_utils.py
build/check_sdk_extras_version.py
build/install-build-deps-android.sh
View unified diff
|
Download patch
« no previous file with comments
|
« build/android/preprocess_google_play_services.py
('k') |
build/android/pylib/utils/argparse_utils.py »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"lib_version": "7.3.0",
3
"clients": [
4
"play-services-base",
5
"play-services-cast",
6
"play-services-identity"
7
],
8
"base_client": "play-services-base",
9
"_comment": [
10
"For the list of locales to keep, generate an android build and list ",
11
"out/Debug/gen/chrome/java/res, or look at the android section in ",
12
"//chrome/app/generated_resources.grd"
13
],
14
"locale_whitelist": [
15
"am",
16
"ar",
17
"bg",
18
"ca",
19
"cs",
20
"da",
21
"de",
22
"el",
23
"en-rGB",
24
"es",
25
"es-rUS",
26
"fa",
27
"fi",
28
"fr",
29
"hi",
30
"hr",
31
"hu",
32
"in",
33
"it",
34
"iw",
35
"ja",
36
"ko",
37
"lt",
38
"lv",
39
"nb",
40
"nl",
41
"pl",
42
"pt-rBR",
43
"pt-rPT",
44
"ro",
45
"ru",
46
"sk",
47
"sl",
48
"sr",
49
"sv",
50
"sw",
51
"th",
52
"tl",
53
"tr",
54
"uk",
55
"vi",
56
"zh-rCN",
57
"zh-rTW"
58
]
59
}
OLD
NEW
« no previous file with comments
|
« build/android/preprocess_google_play_services.py
('k') |
build/android/pylib/utils/argparse_utils.py »
('j') |
no next file with comments »
Issue 1469913002: Cleanup gms update/preprocess scripts, roll android_tools (Closed)
Created 5 years, 1 month ago by dgn
Modified 5 years ago
Reviewers: jbudorick
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 23
This is Rietveld
408576698
Chromium Code Reviews
Issue 1469913002:
Cleanup gms update/preprocess scripts, roll android_tools (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master