Let the MainController dismiss presented modals.

Let the MainController dismiss presented modals.

Prior to this CL, when the ESC key was pressed, only the state presented by the
BVC was dismissed. Moreover, the BVC dismissed blindly all presented view
controller, such as the settings. It is the MainController responsibility to
close the settings, as it is the presenter.
This CL adds a new Chrome command that asks to dismiss all modals.

BUG=none
R=rohitrao@google.com

Review URL: https://chromereviews.googleplex.com/265777013

Committed: https://crrev.com/bca988affc6cc4d47660a18bb48a6785794ec06a
Cr-Commit-Position: refs/heads/master@{#361102}

[sdefresne, 2015-11-23 15:13:05]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org
- rohitrao@google.com

[sdefresne, 2015-11-23 15:13:06]

Please take a look.

lpromero: FYI

[droger, 2015-11-23 15:19:36]

The CQ bit was checked by droger@chromium.org

[droger, 2015-11-23 15:19:36]

lgtm

[commit-bot: I haz the power, 2015-11-23 15:20:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469903002/1

[commit-bot: I haz the power, 2015-11-23 15:28:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-23 15:29:18]

Patchset 1 (id:??) landed as
https://crrev.com/bca988affc6cc4d47660a18bb48a6785794ec06a
Cr-Commit-Position: refs/heads/master@{#361102}

[lpromero, 2015-11-23 15:32:52]

Not sure if I had reused the same description, as it describes internals
more than what the change really is. But it's my fault, since I probably
should have unforked that sooner.

On Mon, Nov 23, 2015 at 4:29 PM commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/bca988affc6cc4d47660a18bb48a6785794ec06a
> Cr-Commit-Position: refs/heads/master@{#361102}
>
> https://codereview.chromium.org/1469903002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-11-23 16:56:19]

I've upstreamed those many CLs using "git format-patch" and "git am". It
was easier for me not to care about the description.
-- Sylvain

On Mon, 23 Nov 2015 at 16:32 Louis Romero <lpromero@chromium.org> wrote:

> Not sure if I had reused the same description, as it describes internals
> more than what the change really is. But it's my fault, since I probably
> should have unforked that sooner.
>
> On Mon, Nov 23, 2015 at 4:29 PM commit-bot@chromium.org via
> codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com>
> wrote:
>
>> Patchset 1 (id:??) landed as
>> https://crrev.com/bca988affc6cc4d47660a18bb48a6785794ec06a
>> Cr-Commit-Position: refs/heads/master@{#361102}
>>
>> https://codereview.chromium.org/1469903002/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[lpromero, 2015-11-23 17:05:37]

Got it. Thanks!

On Mon, Nov 23, 2015 at 5:56 PM Sylvain Defresne <sdefresne@google.com>
wrote:

> I've upstreamed those many CLs using "git format-patch" and "git am". It
> was easier for me not to care about the description.
> -- Sylvain
>
> On Mon, 23 Nov 2015 at 16:32 Louis Romero <lpromero@chromium.org> wrote:
>
>> Not sure if I had reused the same description, as it describes internals
>> more than what the change really is. But it's my fault, since I probably
>> should have unforked that sooner.
>>
>> On Mon, Nov 23, 2015 at 4:29 PM commit-bot@chromium.org via
>> codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com>
>> wrote:
>>
>>> Patchset 1 (id:??) landed as
>>> https://crrev.com/bca988affc6cc4d47660a18bb48a6785794ec06a
>>> Cr-Commit-Position: refs/heads/master@{#361102}
>>>
>>> https://codereview.chromium.org/1469903002/
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.