Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1469883002: Allow in-object properties in JSFunctions. (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow in-object properties in JSFunctions. This CL also fixes HeapObject::IterateFast() and HeapObject::IterateBodyFast(). BUG=v8:4531 LOG=Y Committed: https://crrev.com/4dcba71de7308a7bf2dbd0bf27389bcf6e025b9b Cr-Commit-Position: refs/heads/master@{#32195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M src/heap/scavenger.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M src/objects.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/objects-body-descriptors-inl.h View 4 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Igor Sheludko
PTAL
5 years, 1 month ago (2015-11-23 13:49:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469883002/1
5 years, 1 month ago (2015-11-23 13:49:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-23 14:12:30 UTC) #6
Hannes Payer (out of office)
lgtm
5 years ago (2015-11-24 08:48:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469883002/1
5 years ago (2015-11-24 08:53:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 08:55:13 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 08:55:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4dcba71de7308a7bf2dbd0bf27389bcf6e025b9b
Cr-Commit-Position: refs/heads/master@{#32195}

Powered by Google App Engine
This is Rietveld 408576698