Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1469873003: Allow wait in CommandBufferClientImpl. (Closed)

Created:
5 years ago by Peng
Modified:
5 years ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Fady Samuel, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow wait in CommandBufferClientImpl. BUG=560331 Committed: https://crrev.com/20fa5a639f053d47a31ad7560d3d804ecd1c98dc Cr-Commit-Position: refs/heads/master@{#361154}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M mojo/gles2/command_buffer_client_impl.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Peng
Hi Ben, PTAL. Thanks.
5 years ago (2015-11-23 17:10:08 UTC) #2
Ben Goodger (Google)
lgtm
5 years ago (2015-11-23 18:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469873003/1
5 years ago (2015-11-23 18:27:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/98124) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-11-23 18:29:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469873003/20001
5 years ago (2015-11-23 18:34:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-23 19:27:35 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-23 19:29:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20fa5a639f053d47a31ad7560d3d804ecd1c98dc
Cr-Commit-Position: refs/heads/master@{#361154}

Powered by Google App Engine
This is Rietveld 408576698