Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1469843005: Calculate broken tests threshold based on number of tests in binary, before applying filter (Closed)

Created:
5 years ago by Paweł Hajdan Jr.
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Calculate broken tests threshold based on number of tests in binary, before applying filter BUG=none Committed: https://crrev.com/a81b650f85ebbeba0270d17f566bccffa4988394 Cr-Commit-Position: refs/heads/master@{#361607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M base/test/launcher/test_launcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 4 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Paweł Hajdan Jr.
See e.g. http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133462 for context. It seems to me the current check is too strict, ...
5 years ago (2015-11-24 12:43:51 UTC) #2
sky
LGTM
5 years ago (2015-11-24 16:35:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469843005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469843005/1
5 years ago (2015-11-25 08:02:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 08:07:28 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 08:08:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a81b650f85ebbeba0270d17f566bccffa4988394
Cr-Commit-Position: refs/heads/master@{#361607}

Powered by Google App Engine
This is Rietveld 408576698