Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 1469833005: [runtime] Pass closure to %CreateArrayLiteral and %CreateObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-literals.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc
index 5ed777f61e1bcd45af7f3338885b5628c5cff922..98b3f097414fd3ff2803d519d79f9742ed87708e 100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -1094,7 +1094,7 @@ TEST_F(JSTypedLoweringTest, JSCreateLiteralArray) {
Handle<FixedArray> const constant_elements = factory()->NewFixedArray(12);
int const literal_flags = ArrayLiteral::kShallowElements;
int const literal_index = 1;
- Node* const input = Parameter(0);
+ Node* const closure = Parameter(0);
Node* const context = Parameter(1);
Node* const frame_state = EmptyFrameState();
Node* const effect = graph()->start();
@@ -1102,13 +1102,13 @@ TEST_F(JSTypedLoweringTest, JSCreateLiteralArray) {
Reduction const r = Reduce(
graph()->NewNode(javascript()->CreateLiteralArray(
constant_elements, literal_flags, literal_index),
- input, context, frame_state, effect, control));
+ closure, context, frame_state, effect, control));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
r.replacement(),
IsCall(_, IsHeapConstant(
CodeFactory::FastCloneShallowArray(isolate()).code()),
- input, IsNumberConstant(literal_index),
+ closure, IsNumberConstant(literal_index),
IsHeapConstant(constant_elements), context, frame_state, effect,
control));
}
@@ -1123,7 +1123,7 @@ TEST_F(JSTypedLoweringTest, JSCreateLiteralObject) {
factory()->NewFixedArray(6 * 2);
int const literal_flags = ObjectLiteral::kShallowProperties;
int const literal_index = 1;
- Node* const input = Parameter(0);
+ Node* const closure = Parameter(0);
Node* const context = Parameter(1);
Node* const frame_state = EmptyFrameState();
Node* const effect = graph()->start();
@@ -1131,13 +1131,13 @@ TEST_F(JSTypedLoweringTest, JSCreateLiteralObject) {
Reduction const r = Reduce(
graph()->NewNode(javascript()->CreateLiteralObject(
constant_properties, literal_flags, literal_index),
- input, context, frame_state, effect, control));
+ closure, context, frame_state, effect, control));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
r.replacement(),
IsCall(_, IsHeapConstant(
CodeFactory::FastCloneShallowObject(isolate(), 6).code()),
- input, IsNumberConstant(literal_index),
+ closure, IsNumberConstant(literal_index),
IsHeapConstant(constant_properties), _, context, frame_state,
effect, control));
}
« no previous file with comments | « src/runtime/runtime-literals.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698