src/full-codegen/arm/full-codegen-arm.cc - Issue 1469833005: [runtime] Pass closure to %CreateArrayLiteral and %CreateObjectLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1469833005: [runtime] Pass closure to %CreateArrayLiteral and %CreateObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/arm/full-codegen-arm.cc

diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc

index 683ae6e2d19e82446c8726c1525e41cd09ac0e54..0b56202d032fb7bee2cb5bf065f20deaee68a71e 100644

--- a/src/full-codegen/arm/full-codegen-arm.cc

+++ b/src/full-codegen/arm/full-codegen-arm.cc

@@ -1530,7 +1530,6 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

Handle<FixedArray> constant_properties = expr->constant_properties();

__ ldr(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));

- __ ldr(r3, FieldMemOperand(r3, JSFunction::kLiteralsOffset));

__ mov(r2, Operand(Smi::FromInt(expr->literal_index())));

__ mov(r1, Operand(constant_properties));

int flags = expr->ComputeFlags();

@@ -1738,7 +1737,6 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

}

__ ldr(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));

- __ ldr(r3, FieldMemOperand(r3, JSFunction::kLiteralsOffset));

__ mov(r2, Operand(Smi::FromInt(expr->literal_index())));

__ mov(r1, Operand(constant_elements));

if (MustCreateArrayLiteralWithRuntime(expr)) {

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »