Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1469833005: [runtime] Pass closure to %CreateArrayLiteral and %CreateObjectLiteral. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Pass closure to %CreateArrayLiteral and %CreateObjectLiteral. Change the runtime entries and their associated code stubs for object and array literal creation to take the closure instead of the raw literals pointer. This is way easier to deal with (and cleaner) in TurboFan. R=mstarzinger@chromium.org Committed: https://crrev.com/1b1db13549c0631d50373cfc646a70e1f5d2e32b Cr-Commit-Position: refs/heads/master@{#32220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -56 lines) Patch
M src/code-stubs-hydrogen.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime/runtime-literals.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years ago (2015-11-24 15:11:53 UTC) #1
Benedikt Meurer
Hey Michi, Here's the CL about the cleanup. Please take a look. Thanks, Benedikt
5 years ago (2015-11-24 15:12:44 UTC) #2
Michael Starzinger
LGTM.
5 years ago (2015-11-24 15:22:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469833005/1
5 years ago (2015-11-24 15:41:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 16:05:47 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 16:05:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b1db13549c0631d50373cfc646a70e1f5d2e32b
Cr-Commit-Position: refs/heads/master@{#32220}

Powered by Google App Engine
This is Rietveld 408576698