Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5489)

Unified Diff: chrome/browser/prerender/prerender_contents.h

Issue 146983002: Move pending prerender logic into PrerenderLinkManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_contents.h
diff --git a/chrome/browser/prerender/prerender_contents.h b/chrome/browser/prerender/prerender_contents.h
index fc23008c108b11273acd1e5e75ca6419337840d2..f67a142675d7706ef7bd7bfea7d169c5a6099c65 100644
--- a/chrome/browser/prerender/prerender_contents.h
+++ b/chrome/browser/prerender/prerender_contents.h
@@ -78,7 +78,9 @@ class PrerenderContents : public content::NotificationObserver,
// Signals that the prerender has had its load event.
virtual void OnPrerenderStopLoading(PrerenderContents* contents);
- // Signals that the prerender has stopped running.
+ // Signals that the prerender has stopped running. A PrerenderContents with
+ // an unset final status will always call OnPrerenderStop before being
+ // destroyed.
virtual void OnPrerenderStop(PrerenderContents* contents) = 0;
// Signals that this prerender has just become a MatchComplete replacement.
@@ -90,25 +92,6 @@ class PrerenderContents : public content::NotificationObserver,
virtual ~Observer() = 0;
};
- // A container for extra data on pending prerenders.
- struct PendingPrerenderInfo {
- public:
- PendingPrerenderInfo(
- base::WeakPtr<PrerenderHandle> weak_prerender_handle,
- Origin origin,
- const GURL& url,
- const content::Referrer& referrer,
- const gfx::Size& size);
-
- ~PendingPrerenderInfo();
-
- base::WeakPtr<PrerenderHandle> weak_prerender_handle;
- Origin origin;
- GURL url;
- content::Referrer referrer;
- gfx::Size size;
- };
-
// Indicates how this PrerenderContents relates to MatchComplete. This is to
// figure out which histograms to use to record the FinalStatus, Match (record
// all prerenders and control group prerenders) or MatchComplete (record
@@ -200,10 +183,6 @@ class PrerenderContents : public content::NotificationObserver,
// and returns a boolean indicating the validity of that id.
virtual bool GetRouteId(int* route_id) const;
- // Set the final status for how the PrerenderContents was used. This
- // should only be called once, and should be called before the prerender
- // contents are destroyed.
- void SetFinalStatus(FinalStatus final_status);
FinalStatus final_status() const { return final_status_; }
Origin origin() const { return origin_; }
@@ -289,13 +268,7 @@ class PrerenderContents : public content::NotificationObserver,
// MouseEvent being dispatched by a link to a website installed as an app.
bool IsCrossSiteNavigationPending() const;
- // Adds a pending prerender to the list. If |weak_prerender_handle| still
- // exists when this page is made visible, it will be launched.
- virtual void AddPendingPrerender(
- scoped_ptr<PendingPrerenderInfo> pending_prerender_info);
-
- // Reissues any pending prerender requests from the prerendered page. Also
- // clears the list of pending requests. Sends notifications.
+ // Marks prerender as used and releases any throttled resource requests.
void PrepareForUse();
content::SessionStorageNamespace* GetSessionStorageNamespace() const;
@@ -330,6 +303,11 @@ class PrerenderContents : public content::NotificationObserver,
Origin origin,
uint8 experiment_id);
+ // Set the final status for how the PrerenderContents was used. This
+ // should only be called once, and should be called before the prerender
+ // contents are destroyed.
+ void SetFinalStatus(FinalStatus final_status);
+
// These call out to methods on our Observers, using our observer_list_. Note
// that NotifyPrerenderStop() also clears the observer list.
void NotifyPrerenderStart();
@@ -347,8 +325,6 @@ class PrerenderContents : public content::NotificationObserver,
return notification_registrar_;
}
- size_t pending_prerender_count() const;
-
bool prerendering_has_been_cancelled() const {
return prerendering_has_been_cancelled_;
}
@@ -451,10 +427,6 @@ class PrerenderContents : public content::NotificationObserver,
// Experiment during which this prerender is performed.
uint8 experiment_id_;
- // Prerenders that the prerendered page has tried to prerender. They remain
- // pending until this page is displayed.
- ScopedVector<PendingPrerenderInfo> pending_prerenders_;
-
// The process that created the child id.
int creator_child_id_;
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698