Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6340)

Unified Diff: chrome/browser/prerender/prerender_manager.h

Issue 146983002: Move pending prerender logic into PrerenderLinkManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix prerender_unittests Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.h
diff --git a/chrome/browser/prerender/prerender_manager.h b/chrome/browser/prerender/prerender_manager.h
index 4bfa9d39ff69382779b8e97f6b2555954345b41a..0818d071663ca15d126a9c3ebf1b9ee1aaceeca2 100644
--- a/chrome/browser/prerender/prerender_manager.h
+++ b/chrome/browser/prerender/prerender_manager.h
@@ -230,6 +230,10 @@ class PrerenderManager : public base::SupportsWeakPtr<PrerenderManager>,
PrerenderContents* GetPrerenderContents(
const content::WebContents* web_contents) const;
+ // Same as above, but returns it for a given child_id, route_id pair.
gavinp 2014/01/30 19:58:49 Nit: don't reference another comment. Duplicating
davidben 2014/01/30 21:01:51 Done.
+ virtual PrerenderContents* GetPrerenderContentsForRoute(
+ int child_id, int route_id) const;
+
// Returns a list of all WebContents being prerendered.
const std::vector<content::WebContents*> GetAllPrerenderingContents() const;
@@ -499,13 +503,6 @@ class PrerenderManager : public base::SupportsWeakPtr<PrerenderManager>,
void SetPrerenderContentsFactory(
PrerenderContents::Factory* prerender_contents_factory);
- // Adds prerenders from the pending Prerenders, called by
- // PrerenderContents::StartPendingPrerenders.
- void StartPendingPrerenders(
- int process_id,
- ScopedVector<PrerenderContents::PendingPrerenderInfo>* pending_prerenders,
- content::SessionStorageNamespace* session_storage_namespace);
-
// Called by a PrerenderData to signal that the launcher has navigated away
// from the context that launched the prerender. A user may have clicked
// a link in a page containing a <link rel=prerender> element, or the user
@@ -612,11 +609,6 @@ class PrerenderManager : public base::SupportsWeakPtr<PrerenderManager>,
const GURL& url,
const content::SessionStorageNamespace* session_storage_namespace);
- // If |child_id| and |route_id| correspond to a RenderView that is an active
- // prerender, returns the PrerenderData object for that prerender. Otherwise,
- // returns NULL.
- PrerenderData* FindPrerenderDataForChildAndRoute(int child_id, int route_id);
-
// Given the |prerender_contents|, find the iterator in active_prerenders_
// correponding to the given prerender.
ScopedVector<PrerenderData>::iterator

Powered by Google App Engine
This is Rietveld 408576698