Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1469823004: Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (Closed)

Created:
5 years, 1 month ago by Xianzhu
Modified:
5 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() To ensure layer is set needsRepaint(). BUG=536999 TEST=scrollbars/scrollbar-added-during-drag.html etc with sync painting enabled Committed: https://crrev.com/4c9d4570c68eddbc58f73b1fb4f4c95614bcf9d3 Cr-Commit-Position: refs/heads/master@{#361179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Xianzhu
5 years, 1 month ago (2015-11-23 19:02:42 UTC) #2
Xianzhu
This is one of the last 2 CLs before we can try to enable sync ...
5 years, 1 month ago (2015-11-23 19:03:31 UTC) #3
chrishtr
lgtm
5 years, 1 month ago (2015-11-23 19:03:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469823004/1
5 years, 1 month ago (2015-11-23 19:07:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 20:42:39 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c9d4570c68eddbc58f73b1fb4f4c95614bcf9d3 Cr-Commit-Position: refs/heads/master@{#361179}
5 years, 1 month ago (2015-11-23 20:44:07 UTC) #8
Xianzhu
5 years ago (2015-11-24 17:19:22 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1475483003/ by wangxianzhu@chromium.org.

The reason for reverting is: This is incorrect. We missed setNeedsRepaint() of
the PaintLayers between the object's enclosingLayer and
paintInvalidationContainer's layer..

Powered by Google App Engine
This is Rietveld 408576698