Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1469823003:
Add CT DM isolate file and script that will be run on swarming slaves (Closed)
DescriptionAdd CT DM isolate file and script that will be run on swarming slaves.
The code here will be invoked by the recipe in https://codereview.chromium.org/1441173003/
BUG=skia:2545
Committed: https://crrev.com/e0df8b98317e0967d30ea4a7c4a47ad42a1eb2cf
Cr-Commit-Position: refs/heads/master@{#361666}
Patch Set 1 : Initial upload #Patch Set 2 : Checkpoint #Patch Set 3 : More progress #Patch Set 4 : Checkpoint #Patch Set 5 : Cleanup #
Total comments: 8
Patch Set 6 : Address comments #Patch Set 7 : Minor fix to skps path #Messages
Total messages: 26 (12 generated)
Description was changed from ========== Add CT DM isolate file and script that will be run on swarming slaves BUG=skia:2545 ========== to ========== Add CT DM isolate file and script that will be run on swarming slaves. The code here will be invoked by the recipe in https://codereview.chromium.org/1441173003/ BUG=skia:2545 ==========
rmistry@google.com changed reviewers: + maruel@chromium.org, phajdan.jr@chromium.org
The CQ bit was checked by rmistry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469823003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469823003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by rmistry@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469823003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469823003/80001
https://codereview.chromium.org/1469823003/diff/80001/chrome/ct_dm.isolate File chrome/ct_dm.isolate (right): https://codereview.chromium.org/1469823003/diff/80001/chrome/ct_dm.isolate#ne... chrome/ct_dm.isolate:11: '../../skia/out/Debug/dm', That's a bit sad to hard code this here. https://codereview.chromium.org/1469823003/diff/80001/content/test/ct/run_ct_... File content/test/ct/run_ct_dm.py (right): https://codereview.chromium.org/1469823003/diff/80001/content/test/ct/run_ct_... content/test/ct/run_ct_dm.py:18: return os.path.abspath(os.path.join( you mean normpath() instead of abspath(). But since it's a constant, make it a constant at line 27 https://codereview.chromium.org/1469823003/diff/80001/content/test/ct/run_ct_... content/test/ct/run_ct_dm.py:24: parser.add_argument('-s', '--slave_num', required=True, type=int? https://codereview.chromium.org/1469823003/diff/80001/content/test/ct/run_ct_... content/test/ct/run_ct_dm.py:28: dm_path = os.path.join(_GetSkiaSrcDir(), 'out', 'Debug', 'dm') Could the relative path be a flag that defaults to Debug or you don't see it ever changing? (E.g. Debug_x64)
Patchset #6 (id:100001) has been deleted
https://codereview.chromium.org/1469823003/diff/80001/chrome/ct_dm.isolate File chrome/ct_dm.isolate (right): https://codereview.chromium.org/1469823003/diff/80001/chrome/ct_dm.isolate#ne... chrome/ct_dm.isolate:11: '../../skia/out/Debug/dm', On 2015/11/24 19:07:34, M-A Ruel wrote: > That's a bit sad to hard code this here. This meaning "Debug"? if so spoke about this in the next comment. https://codereview.chromium.org/1469823003/diff/80001/content/test/ct/run_ct_... File content/test/ct/run_ct_dm.py (right): https://codereview.chromium.org/1469823003/diff/80001/content/test/ct/run_ct_... content/test/ct/run_ct_dm.py:18: return os.path.abspath(os.path.join( On 2015/11/24 19:07:34, M-A Ruel wrote: > you mean normpath() instead of abspath(). > > But since it's a constant, make it a constant at line 27 Done. https://codereview.chromium.org/1469823003/diff/80001/content/test/ct/run_ct_... content/test/ct/run_ct_dm.py:24: parser.add_argument('-s', '--slave_num', required=True, On 2015/11/24 19:07:34, M-A Ruel wrote: > type=int? Done. https://codereview.chromium.org/1469823003/diff/80001/content/test/ct/run_ct_... content/test/ct/run_ct_dm.py:28: dm_path = os.path.join(_GetSkiaSrcDir(), 'out', 'Debug', 'dm') On 2015/11/24 19:07:34, M-A Ruel wrote: > Could the relative path be a flag that defaults to Debug or you don't see it > ever changing? (E.g. Debug_x64) I do not see it ever changing. But I have been wrong before, in which case I will add the flag if it ever changes :)
lgtm
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469823003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469823003/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
LGTM
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469823003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469823003/120001
The CQ bit was unchecked by rmistry@google.com
The CQ bit was checked by rmistry@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org, phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/1469823003/#ps140001 (title: "Minor fix to skps path")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469823003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469823003/140001
Message was sent while issue was closed.
Committed patchset #7 (id:140001)
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/e0df8b98317e0967d30ea4a7c4a47ad42a1eb2cf Cr-Commit-Position: refs/heads/master@{#361666} |
