Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/push_messaging/resources/interfaces-worker.js

Issue 1469813004: Address two minor FIXMEs in Push Messaging layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 importScripts('/resources/testharness.js'); 1 importScripts('/resources/testharness.js');
2 importScripts('/resources/testharness-helpers.js'); 2 importScripts('/resources/testharness-helpers.js');
3 3
4 test(function() { 4 test(function() {
5 assert_own_property(self, 'PushEvent'); 5 assert_own_property(self, 'PushEvent');
6 6
7 var event = new PushEvent('PushEvent'); 7 var event = new PushEvent('PushEvent');
8 assert_will_be_idl_attribute(event, 'data'); 8 assert_will_be_idl_attribute(event, 'data');
9 assert_equals(event.type, 'PushEvent'); 9 assert_equals(event.type, 'PushEvent');
10 10
(...skipping 19 matching lines...) Expand all
30 assert_inherits(pushMessageData, 'arrayBuffer'); 30 assert_inherits(pushMessageData, 'arrayBuffer');
31 assert_inherits(pushMessageData, 'blob'); 31 assert_inherits(pushMessageData, 'blob');
32 assert_inherits(pushMessageData, 'json'); 32 assert_inherits(pushMessageData, 'json');
33 assert_inherits(pushMessageData, 'text'); 33 assert_inherits(pushMessageData, 'text');
34 34
35 }, 'PushMessageData should be exposed and have the expected interface.'); 35 }, 'PushMessageData should be exposed and have the expected interface.');
36 36
37 test(function() { 37 test(function() {
38 assert_own_property(self, 'PushSubscription', 'PushSubscription needs to be exposed as a global.'); 38 assert_own_property(self, 'PushSubscription', 'PushSubscription needs to be exposed as a global.');
39 39
40 // FIXME: Assert existence of the attributes when they are properly 40 assert_own_property(PushSubscription.prototype, 'endpoint');
41 // exposed in the prototype chain. https://crbug.com/43394
42 41
42 assert_own_property(PushSubscription.prototype, 'getKey');
43 assert_own_property(PushSubscription.prototype, 'unsubscribe'); 43 assert_own_property(PushSubscription.prototype, 'unsubscribe');
44 44
45 }, 'PushSubscription should be exposed and have the expected interface.'); 45 }, 'PushSubscription should be exposed and have the expected interface.');
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698