Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1469813003: Revert of The AllUrlsApiTest.WhitelistedExtension test should no longer flake. (Closed)

Created:
5 years, 1 month ago by magjed_chromium
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of The AllUrlsApiTest.WhitelistedExtension test should no longer flake. (patchset #3 id:40001 of https://codereview.chromium.org/1442593002/ ) Reason for revert: The WhitelistedExtension is still flaky on the XP Tests bot, see e.g. https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/41174 stdio output: [ RUN ] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages [1636:4084:1120/124530:WARNING:raw_channel.cc(208)] Shutting down RawChannel with write buffer nonempty [139/464] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages (TIMED OUT) Original issue's description: > The AllUrlsApiTest.WhitelistedExtension test should no longer flake. > > The test had begun to hang after the refactoring that changed the way the extensions are loaded and reloaded. As a result of that refactoring, the test loaded the pages and tried to get some response from the extensions before they had time to reload. > > This change introduces waiting for the extensions reload, so the test should no longer flake. > > BUG=174341 > > R=finnur@chromium.org > > Committed: https://crrev.com/454083864ede93660c2f08cf7d0e06ca10013c0d > Cr-Commit-Position: refs/heads/master@{#359537} TBR=finnur@chromium.org,voodoo@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true BUG=174341 Committed: https://crrev.com/0f33acbbc2fcee3068925f3b0b45955ab01802a9 Cr-Commit-Position: refs/heads/master@{#361090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -35 lines) Patch
M chrome/browser/extensions/all_urls_apitest.cc View 3 chunks +15 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
magjed_chromium
Created Revert of The AllUrlsApiTest.WhitelistedExtension test should no longer flake.
5 years, 1 month ago (2015-11-23 11:15:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469813003/1
5 years, 1 month ago (2015-11-23 11:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469813003/1
5 years, 1 month ago (2015-11-23 11:17:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 11:49:47 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 11:50:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f33acbbc2fcee3068925f3b0b45955ab01802a9
Cr-Commit-Position: refs/heads/master@{#361090}

Powered by Google App Engine
This is Rietveld 408576698