chrome/browser/popup_blocker_browsertest.cc - Issue 14698028: Omnibox refactor. OmniboxController now holds an AutocompleteMatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/popup_blocker_browsertest.cc

Issue 14698028: Omnibox refactor. OmniboxController now holds an AutocompleteMatch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed failing browser tests. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/popup_blocker_browsertest.cc

diff --git a/chrome/browser/popup_blocker_browsertest.cc b/chrome/browser/popup_blocker_browsertest.cc

index e7ec7f209e8f612c0bbf97878e12f5b6048e38ca..cfb3190dec18af92ee57ecf3d5b03af23d902406 100644

--- a/chrome/browser/popup_blocker_browsertest.cc

+++ b/chrome/browser/popup_blocker_browsertest.cc

@@ -178,8 +178,8 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,

LocationBar* location_bar = browser()->window()->GetLocationBar();

ui_test_utils::SendToOmniboxAndSubmit(location_bar, search_string);

OmniboxEditModel* model = location_bar->GetLocationEntry()->model();

- EXPECT_EQ(GURL(search_string), model->CurrentMatch().destination_url);

- EXPECT_EQ(ASCIIToUTF16(search_string), model->CurrentMatch().contents);

+ EXPECT_EQ(GURL(search_string), model->CurrentMatch(NULL).destination_url);

+ EXPECT_EQ(ASCIIToUTF16(search_string), model->CurrentMatch(NULL).contents);

}

} // namespace