chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc - Issue 14698028: Omnibox refactor. OmniboxController now holds an AutocompleteMatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

Issue 14698028: Omnibox refactor. OmniboxController now holds an AutocompleteMatch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed failing browser tests. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc b/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

index b876ffebbaf7b4f9238620fd9c983dc3383da14a..4c994c0c648c481037b0beae4a0fc5f38f3e3f67 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

@@ -160,7 +160,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, OnInputEntered) {

AutocompleteController* autocomplete_controller =

GetAutocompleteController(browser());

omnibox_view->OnBeforePossibleChange();

- omnibox_view->SetUserText(string16());

+ omnibox_view->SetUserText(ASCIIToUTF16("keyword command"));

omnibox_view->OnAfterPossibleChange();

autocomplete_controller->Start(

@@ -175,7 +175,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, OnInputEntered) {

EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();

omnibox_view->OnBeforePossibleChange();

- omnibox_view->SetUserText(string16());

+ omnibox_view->SetUserText(ASCIIToUTF16("keyword newtab"));

omnibox_view->OnAfterPossibleChange();

WaitForAutocompleteDone(autocomplete_controller);

EXPECT_TRUE(autocomplete_controller->done());