Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14698023: Remove some unused guards. (Closed)

Created:
7 years, 7 months ago by kbalazs_
Modified:
7 years, 6 months ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, Nate Chapin, jeez, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove some unused guards. Removed GESTURE_RECOGNIZER (always off), CACHE_PARTITIONING (always off) and __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 (JavaScriptCore related). NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151569

Patch Set 1 #

Patch Set 2 : Remove some unused guards. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M Source/WebKit/chromium/src/WebPopupMenuImpl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/wtf/FastMalloc.cpp View 1 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
kbalazs_
Another simple cleanup, removing some flags that are not needed in the Blink era.
7 years, 6 months ago (2013-05-28 16:17:02 UTC) #1
abarth-chromium
LGTM
7 years, 6 months ago (2013-05-28 16:18:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14698023/2001
7 years, 6 months ago (2013-05-28 16:18:43 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-28 16:34:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14698023/2001
7 years, 6 months ago (2013-05-28 16:53:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7698
7 years, 6 months ago (2013-05-28 18:18:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14698023/2001
7 years, 6 months ago (2013-05-28 19:26:42 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7733
7 years, 6 months ago (2013-05-28 20:50:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14698023/2001
7 years, 6 months ago (2013-05-30 18:48:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=8134
7 years, 6 months ago (2013-05-30 20:13:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14698023/2001
7 years, 6 months ago (2013-05-31 09:52:27 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8029
7 years, 6 months ago (2013-05-31 11:44:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14698023/2001
7 years, 6 months ago (2013-05-31 19:20:37 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 19:20:51 UTC) #14
Message was sent while issue was closed. 
Change committed as 151569

Powered by Google App Engine
This is Rietveld 408576698