Issue 14698013: Report CompileTimeErrorCode.MIXIN_REFERENCES_SUPER

Issue 14698013: Report CompileTimeErrorCode.MIXIN_REFERENCES_SUPER (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report CompileTimeErrorCode.MIXIN_REFERENCES_SUPER R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22569

Patch Set 2 : Fixes for review comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -33 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ClassElementImpl.java	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/Modifier.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/handle/ClassElementHandle.java	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java	View	1	7 chunks	+24 lines, -10 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	2 chunks	+19 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1	2 chunks	+11 lines, -11 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/SimpleResolverTest.java	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/14698013/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java (right): https://codereview.chromium.org/14698013/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java#newcode130 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java:130: public boolean isReferencesSuper(); I think either "hasReferenceToSuper" or ...

7 years, 7 months ago (2013-05-09 20:41:37 UTC) #2

scheglov

Committed patchset #2 manually as r22569 (presubmit successful).

7 years, 7 months ago (2013-05-09 21:23:39 UTC) #3

scheglov

7 years, 7 months ago (2013-05-09 21:23:50 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14698013/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java
(right):

https://codereview.chromium.org/14698013/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java:130:
public boolean isReferencesSuper();
On 2013/05/09 20:41:37, Brian Wilkerson wrote:
> I think either "hasReferenceToSuper" or "referencesSuper" would be better
names
> for this method.

Done.

https://codereview.chromium.org/14698013/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java
(right):

https://codereview.chromium.org/14698013/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java:670:
private boolean isReferencesSuper(ClassDeclaration node) {
On 2013/05/09 20:41:37, Brian Wilkerson wrote:
> I suspect that it would be more efficient to set an instance field declared in
> TypeResolverVisitor to false before visiting a class declaration, add the
> visitSuperExpression method to TypeResolverVisitor, and then access the
instance
> field. That way we'd only visit the structure once instead of visiting
> everything within a class definition twice.

Done.

Expand Messages | Collapse Messages