Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1469783002: Cleanup: Correctly spell success(ful). (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, asanka, sadrul, yusukes+watch_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, mlamouri+watch-screen-orientation_chromium.org, jam, Michael van Ouwerkerk, browser-components-watch_chromium.org, bondd+autofillwatch_chromium.org, scheib+watch_chromium.org, dgrogan, bradnelson+warch_chromium.org, tracing+reviews_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, blink-reviews, cbentzel+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, pvalenzuela+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, posciak+watch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, kalyank, xjz+watch_chromium.org, tzik, ihf+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, rouslan+autofill_chromium.org, jasonroberts+watch_google.com, mlamouri+watch-notifications_chromium.org, rickyz+watch_chromium.org, binji+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, caitkp+watch_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jsbell+idb_chromium.org, jochen+watch_chromium.org, sdefresne+watch_chromium.org, Peter Beverloo, mlamouri+watch-test-runner_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, teravest+watch_chromium.org, plaree+watch_chromium.org, cmumford, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, isheriff+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Correctly spell success(ful). TBR=brettw@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/259626c7ca1971bca226343df8d88c2b44530158 Cr-Commit-Position: refs/heads/master@{#361166}

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : Fix layout tests #

Patch Set 4 : git cl format media #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -130 lines) Patch
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/ContentUriUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ResetDataActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_elf_init_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_xml_parser_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/history/core/browser/history_types.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/pnacl_translation_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/proximity_auth/cryptauth/pref_names.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/tracing/child_trace_message_filter_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/content/renderer/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/ios/browser/ios_translate_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/notification_event_dispatcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/safe_util_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 4 chunks +18 lines, -18 lines 0 comments Download
M courgette/courgette.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/symmetric_key_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gin/converter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/find_in_page/find_in_page_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/find_in_page/js_findinpage_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/find_in_page/js_findinpage_manager.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/crw_browsing_data_store_unittest.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/mac/platform_video_capturing_mac.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M media/capture/video/mac/video_capture_device_avfoundation_mac.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M media/capture/video/mac/video_capture_device_qtkit_mac.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M media/cast/sender/video_sender_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M net/der/parse_values.h View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/threaded_ssl_private_key.h View 1 chunk +1 line, -1 line 0 comments Download
M pdf/document_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/ppb_compositor.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/ppb_compositor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/video_encoder_resource_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_cups.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M rlz/lib/rlz_lib.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/src/app_container.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 3 chunks +1 line, -3 lines 0 comments Download
M sync/syncable/directory.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/painting-on-bad-canvas.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/font-face-download-error.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/compatMode-AlmostStrict.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/compatMode-AlmostStrict-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/compatMode-Compat.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/compatMode-Compat-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/compatMode-Strict.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/compatMode-Strict-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-input-after-composition.html View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/jquery/resources/test/unit/ajax.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/ManualTests/goBack-blank-tab-page.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/ManualTests/resources/before-go-back.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Lei Zhang
TBR, all try bots reporting success.
5 years, 1 month ago (2015-11-23 18:04:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469783002/40001
5 years, 1 month ago (2015-11-23 18:05:47 UTC) #5
Will Harris
I admire your pasion for correkt speeling.
5 years, 1 month ago (2015-11-23 18:08:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/121311)
5 years, 1 month ago (2015-11-23 18:22:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469783002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469783002/60001
5 years, 1 month ago (2015-11-23 18:40:38 UTC) #11
brettw
rs lgtm
5 years, 1 month ago (2015-11-23 19:24:19 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-23 20:18:20 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 20:19:26 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/259626c7ca1971bca226343df8d88c2b44530158
Cr-Commit-Position: refs/heads/master@{#361166}

Powered by Google App Engine
This is Rietveld 408576698