Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1469733004: Moves components/mus/examples into mash (Closed)

Created:
5 years ago by sky
Modified:
5 years ago
CC:
chromium-reviews, rjkroege, sadrul, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, penghuang+watch-mandoline_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves components/mus/examples into mash BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/13082723eca36efd15895d77b5bb099aa80257ba Cr-Commit-Position: refs/heads/master@{#361177}

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : tweaks #

Patch Set 4 : git add #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1093 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D components/mus/example/BUILD.gn View 1 chunk +0 lines, -39 lines 0 comments Download
D components/mus/example/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/mus/example/common/mus_views_init.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/mus/example/main/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
D components/mus/example/main/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/mus/example/main/main_application_delegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
D components/mus/example/main/main_application_delegate.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D components/mus/example/mock_sysui/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
D components/mus/example/mock_sysui/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/mus/example/mock_sysui/mock_sysui.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/mus/example/mock_sysui/mock_sysui.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D components/mus/example/views_examples/BUILD.gn View 1 chunk +0 lines, -40 lines 0 comments Download
D components/mus/example/views_examples/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/mus/example/views_examples/views_examples_application_delegate.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/mus/example/views_examples/views_examples_application_delegate.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D components/mus/example/window_type_launcher/BUILD.gn View 1 chunk +0 lines, -57 lines 0 comments Download
D components/mus/example/window_type_launcher/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D components/mus/example/window_type_launcher/main.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D components/mus/example/window_type_launcher/window_type_launcher.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/mus/example/window_type_launcher/window_type_launcher.cc View 1 chunk +0 lines, -367 lines 0 comments Download
M mandoline/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mash/BUILD.gn View 1 2 3 1 chunk +3 lines, -16 lines 0 comments Download
A mash/example/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A + mash/example/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mash/example/common/mus_views_init.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + mash/example/main/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + mash/example/main/main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mash/example/main/main_application_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mash/example/main/main_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mash/example/mock_sysui/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mash/example/mock_sysui/main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mash/example/mock_sysui/mock_sysui.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mash/example/mock_sysui/mock_sysui.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mash/example/views_examples/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mash/example/views_examples/main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mash/example/views_examples/views_examples_application_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mash/example/views_examples/views_examples_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mash/example/window_type_launcher/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mash/example/window_type_launcher/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mash/example/window_type_launcher/main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mash/example/window_type_launcher/window_type_launcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +4 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.win.json View 3 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sky
5 years ago (2015-11-23 18:57:32 UTC) #3
Ben Goodger (Google)
lgtm
5 years ago (2015-11-23 19:01:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469733004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469733004/40001
5 years ago (2015-11-23 19:04:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/110644)
5 years ago (2015-11-23 19:08:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469733004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469733004/60001
5 years ago (2015-11-23 19:12:10 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-11-23 20:41:18 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-23 20:43:03 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/13082723eca36efd15895d77b5bb099aa80257ba
Cr-Commit-Position: refs/heads/master@{#361177}

Powered by Google App Engine
This is Rietveld 408576698