Issue 146973007: Kill NodeListNameCacheMap cache in NodeListsNodeData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146973007: Kill NodeListNameCacheMap cache in NodeListsNodeData (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
eseidel, adamk, abarth-chromium

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Kill NodeListNameCacheMap cache in NodeListsNodeData Kill NodeListNameCacheMap cache in NodeListsNodeData. These days, all node lists use an atomic name so this is unused code. R=eseidel, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166831

Patch Set 1 #

Patch Set 2 : Move method to better location #

Patch Set 3 : Remove additional unused method #

Patch Set 4 : Rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -64 lines)			Patch
M	Source/core/dom/Node.cpp	View	1 2 3	1 chunk	+0 lines, -18 lines	0 comments	Download
M	Source/core/dom/NodeRareData.h	View	1 2 3	8 chunks	+2 lines, -46 lines	0 comments	Download
M	Source/core/dom/NodeRareData.cpp	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/146973007/140001

6 years, 10 months ago (2014-02-10 13:30:28 UTC) #5

Message was sent while issue was closed.

Change committed as 166831

Expand Messages | Collapse Messages