Issue 146973006: Use isFinishedParsingChildren() in HTMLSelectElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146973006: Use isFinishedParsingChildren() in HTMLSelectElement (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
Mike West

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use isFinishedParsingChildren() in HTMLSelectElement Remove HTMLSelectElement::m_isParsingInProgress and HTMLSelectElement::isParsingInProgress(). There is no runtime change, as isFinishedParsingChildren() is true per default, even for script-created elements, and only returns false between the beginParsingChildren() and finishParsingChildren(). BUG=341414 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166637

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -13 lines)			Patch
M	Source/core/html/HTMLOptionElement.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.h	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLTagNames.in	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/146973006/1

6 years, 10 months ago (2014-02-06 17:07:20 UTC) #4

Message was sent while issue was closed.

Change committed as 166637

Expand Messages | Collapse Messages