Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 146973005: Don't access stack-allocated variable when it is out of scope. Enable Isolate cleanup in cctests ag… (Closed)

Created:
6 years, 10 months ago by Sven Panne
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Don't access stack-allocated variable when it is out of scope. Enable Isolate cleanup in cctests again. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M test/cctest/cctest.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
6 years, 10 months ago (2014-02-04 12:08:49 UTC) #1
Sven Panne
6 years, 10 months ago (2014-02-04 12:08:50 UTC) #2
ulan
lgtm
6 years, 10 months ago (2014-02-04 12:22:04 UTC) #3
Sven Panne
6 years, 10 months ago (2014-02-04 12:23:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19068 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698