Cache for mDNS records

net/dns/record_rdata_unittest.cc

Index: net/dns/record_rdata_unittest.cc
diff --git a/net/dns/record_rdata_unittest.cc b/net/dns/record_rdata_unittest.cc
index c046b6f40fe87f5c43be8c69e3566a90bb6c82c6..214069dc9e96d8d18fa437af2a181dc7eb654f21 100644
--- a/net/dns/record_rdata_unittest.cc
+++ b/net/dns/record_rdata_unittest.cc
@@ -52,6 +52,9 @@ TEST(RecordRdataTest, ParseSrvRecord) {
   ASSERT_EQ(259, record2_obj->port());
 
   ASSERT_EQ("www2.google.com", record2_obj->target());
+
+  ASSERT_TRUE(record1_obj->IsEqual(record1_obj.get()));
+  ASSERT_FALSE(record1_obj->IsEqual(record2_obj.get()));
 }
 
 TEST(RecordRdataTest, ParseARecord) {
@@ -71,6 +74,33 @@ TEST(RecordRdataTest, ParseARecord) {
   ASSERT_TRUE(record_obj != NULL);
 
   ASSERT_EQ("127.0.0.1", IPAddressToString(record_obj->address()));
+
+  ASSERT_TRUE(record_obj->IsEqual(record_obj.get()));
+}
+
+TEST(RecordRdataTest, ParseAAAARecord) {
+  scoped_ptr<AAAARecordRdata> record_obj;
+
+  // These are just the rdata portions of the DNS records, rather than complete
+  // records, but it works well enough for this test.
+
+  const char record[] = {
+    0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0x01  // ::1

[szym, 2013/05/21 22:09:05]

I'd suggest something slightly more complex than that.

[Noam Samuel, 2013/05/21 23:00:56]

Done.

+  };
+
+  DnsRecordParser parser(record, sizeof(record), 0);
+  base::StringPiece record_strpiece(record, sizeof(record));
+
+  record_obj = AAAARecordRdata::Create(record_strpiece, parser);
+  ASSERT_TRUE(record_obj != NULL);
+
+  ASSERT_EQ("::1",
+            IPAddressToString(record_obj->address()));

[szym, 2013/05/21 22:09:05]

You need to include net_util.h for that.

[Noam Samuel, 2013/05/21 23:00:56]

Done.

+
+  ASSERT_TRUE(record_obj->IsEqual(record_obj.get()));
 }
 
 TEST(RecordRdataTest, ParseCnameRecord) {
@@ -93,6 +123,8 @@ TEST(RecordRdataTest, ParseCnameRecord) {
   ASSERT_TRUE(record_obj != NULL);
 
   ASSERT_EQ("www.google.com", record_obj->cname());
+
+  ASSERT_TRUE(record_obj->IsEqual(record_obj.get()));
 }
 
 TEST(RecordRdataTest, ParsePtrRecord) {
@@ -115,6 +147,8 @@ TEST(RecordRdataTest, ParsePtrRecord) {
   ASSERT_TRUE(record_obj != NULL);
 
   ASSERT_EQ("www.google.com", record_obj->ptrdomain());
+
+  ASSERT_TRUE(record_obj->IsEqual(record_obj.get()));
 }
 
 TEST(RecordRdataTest, ParseTxtRecord) {
@@ -141,6 +175,8 @@ TEST(RecordRdataTest, ParseTxtRecord) {
   expected.push_back("com");
 
   ASSERT_EQ(expected, record_obj->texts());
+
+  ASSERT_TRUE(record_obj->IsEqual(record_obj.get()));
 }
 
 }  // namespace net