Cache for mDNS records

net/dns/record_parsed.h

Index: net/dns/record_parsed.h
diff --git a/net/dns/record_parsed.h b/net/dns/record_parsed.h
index da58b2661303f5f4f0fc8e549b2b8cff0388fdc4..9520ff9ac6c0a70ae4d120a597243f27ea743b04 100644
--- a/net/dns/record_parsed.h
+++ b/net/dns/record_parsed.h
@@ -7,6 +7,7 @@
 
 #include <string>
 
+#include "base/time.h"

[szym, 2013/05/20 19:35:15]

header order

[Noam Samuel, 2013/05/20 21:07:02]

Fixed.

On 2013/05/20 19:35:15, szym wrote:

 #include "base/memory/scoped_ptr.h"
 #include "net/base/net_export.h"
 
@@ -19,25 +20,35 @@ class RecordRdata;
 // has been parsed into a data structure.
 class NET_EXPORT_PRIVATE RecordParsed {
  public:
+  RecordParsed(const RecordParsed&);

[szym, 2013/05/20 19:35:15]

Do you need this?

[Noam Samuel, 2013/05/20 21:07:02]

It's used to pass RecordParsed objects asynchronously through the message loop.

[szym, 2013/05/20 21:13:03]

It's not used in this CL. I know it's a hassle, but could you move it (and the
tests) to the CL that will need it?

[szym, 2013/05/20 21:20:50]

Also, Google style suggests using just CopyFrom() or Clone() rather than the
copy constructor, unless some STL-dependent code needs a copy constructor.

   virtual ~RecordParsed();
 
   // All records are inherently immutable. Return a const pointer.
-  static scoped_ptr<const RecordParsed> CreateFrom(DnsRecordParser* parser);
+  static scoped_ptr<const RecordParsed> CreateFrom(DnsRecordParser* parser,
+                                                   base::Time time_created);
 
   const std::string& name() const { return name_; }
   uint16 type() const { return type_; }
   uint16 klass() const { return klass_; }
   uint32 ttl() const { return ttl_; }
 
+  base::Time time_created() const { return time_created_; }
+
   template <class T> const T* rdata() const {
     if (T::kType != type_)
       return NULL;
     return static_cast<const T*>(rdata_.get());
   }
 
+  // Check if two records have the same data. Ignores time_created and ttl.
+  // If |is_mdns| is true, ignore the top bit of the class
+  // (the cache flush bit).
+  bool IsEqual(const RecordParsed* other, bool is_mdns) const;
+
  private:
-  RecordParsed(const std::string& name, uint16 type, uint16 klass, uint32 ttl,
-               scoped_ptr<const RecordRdata> rdata);
+  RecordParsed(const std::string& name, uint16 type, uint16 klass,
+               uint32 ttl, scoped_ptr<const RecordRdata> rdata,
+               base::Time time_created);
 
   std::string name_;  // in dotted form
   const uint16 type_;
@@ -46,7 +57,7 @@ class NET_EXPORT_PRIVATE RecordParsed {
 
   const scoped_ptr<const RecordRdata> rdata_;
 
-  DISALLOW_COPY_AND_ASSIGN(RecordParsed);
+  const base::Time time_created_;
 };
 
 }  // namespace net