Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 146963007: Teach locales about *BSD (Closed)

Created:
6 years, 10 months ago by r.c.ladan
Modified:
6 years, 10 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Teach locales about *BSD BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250353

Patch Set 1 #

Patch Set 2 : Use pp_ifdef('desktop_linux') #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/base/strings/app_locale_settings.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_bn.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ja.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ko.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ml.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_th.xtb View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
r.c.ladan
6 years, 10 months ago (2014-02-03 23:00:07 UTC) #1
r.c.ladan
On 2014/02/03 23:00:07, r.c.ladan wrote: Wondering if it would be possible/desirable to replace (is_linux or ...
6 years, 10 months ago (2014-02-10 22:15:39 UTC) #2
Ben Goodger (Google)
I'm not a locale expert, so I don't know but at face value does sound ...
6 years, 10 months ago (2014-02-11 00:08:02 UTC) #3
tony
Using pp_ifdef('desktop_linux') seems better to me in case someone on solaris comes by and wants ...
6 years, 10 months ago (2014-02-11 00:17:48 UTC) #4
r.c.ladan
On 2014/02/11 00:17:48, tony wrote: > Using pp_ifdef('desktop_linux') seems better to me in case someone ...
6 years, 10 months ago (2014-02-11 00:32:12 UTC) #5
tony
LGTM
6 years, 10 months ago (2014-02-11 00:34:41 UTC) #6
r.c.ladan
The CQ bit was checked by r.c.ladan@gmail.com
6 years, 10 months ago (2014-02-11 00:35:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/146963007/70001
6 years, 10 months ago (2014-02-11 00:36:59 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 04:56:59 UTC) #9
Message was sent while issue was closed.
Change committed as 250353

Powered by Google App Engine
This is Rietveld 408576698