Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 146963006: Move blob/mock_blob_url_request_context to content/ (Closed)

Created:
6 years, 11 months ago by pilgrim_google
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tzik, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, darin (slow to review)
Visibility:
Public.

Description

Move blob/mock_blob_url_request_context to content/ BUG=338338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247618

Patch Set 1 #

Patch Set 2 : incorporate jam's feedback #

Patch Set 3 : fix one more using clause #

Total comments: 1

Patch Set 4 : nits #

Patch Set 5 : one missed using #

Patch Set 6 : fix duplicate GYPI entries (should fix link errors on Android and Win) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -141 lines) Patch
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/test/mock_blob_url_request_context.h View 1 2 3 3 chunks +12 lines, -10 lines 0 comments Download
A + content/public/test/mock_blob_url_request_context.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download
D webkit/browser/blob/mock_blob_url_request_context.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webkit/browser/blob/mock_blob_url_request_context.cc View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
pilgrim_google
This fails checkdeps because chrome/blob/ can not rely on content/blob/. I'm new at this refactoring ...
6 years, 11 months ago (2014-01-27 15:33:23 UTC) #1
jam
On 2014/01/27 15:33:23, pilgrim_google wrote: > This fails checkdeps because chrome/blob/ can not rely on ...
6 years, 11 months ago (2014-01-27 16:08:18 UTC) #2
pilgrim_google
6 years, 11 months ago (2014-01-27 19:24:24 UTC) #3
pilgrim_google
6 years, 11 months ago (2014-01-27 19:25:47 UTC) #4
pilgrim_google
6 years, 11 months ago (2014-01-27 19:43:17 UTC) #5
jam
lgtm https://codereview.chromium.org/146963006/diff/60001/content/public/test/mock_blob_url_request_context.h File content/public/test/mock_blob_url_request_context.h (right): https://codereview.chromium.org/146963006/diff/60001/content/public/test/mock_blob_url_request_context.h#newcode5 content/public/test/mock_blob_url_request_context.h:5: #ifndef CONTENT_MOCK_BLOB_URL_REQUEST_CONTEXT_H_ nit: CONTENT_PUBLIC_TEST_MOCK_BLOB_URL_REQUEST_CONTEXT_H_
6 years, 10 months ago (2014-01-28 16:06:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/146963006/100001
6 years, 10 months ago (2014-01-28 18:27:10 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=46801
6 years, 10 months ago (2014-01-28 18:48:11 UTC) #8
pilgrim_google
On 2014/01/28 18:48:11, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-01-28 19:19:46 UTC) #9
pilgrim_google
Still needs an OWNER in webkit/
6 years, 10 months ago (2014-01-28 19:20:37 UTC) #10
michaeln
lgtm2
6 years, 10 months ago (2014-01-28 21:39:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/146963006/100001
6 years, 10 months ago (2014-01-28 21:46:21 UTC) #12
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=110220
6 years, 10 months ago (2014-01-28 23:01:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/146963006/120001
6 years, 10 months ago (2014-01-29 01:19:25 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 05:03:29 UTC) #15
Message was sent while issue was closed.
Change committed as 247618

Powered by Google App Engine
This is Rietveld 408576698