Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 146963004: Exclude print_preview resources for platforms that don't use it (Closed)

Created:
6 years, 11 months ago by aurimas (slooooooooow)
Modified:
6 years, 11 months ago
Reviewers:
Lei Zhang, boliu
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude print_preview resources for platforms that don't use it Only enable_printing==1 uses print_preview and all of its resources. enable_printing==2 and enable_printing==0 do not need them. BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247291

Patch Set 1 #

Patch Set 2 : Renamed IDS_PRINT_PREVIEW_INVALID_PRINTER_SETTINGS #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -262 lines) Patch
M android_webview/renderer/print_web_view_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +260 lines, -256 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aurimas (slooooooooow)
Hey Lei, Please take a look at this change. Thanks, Aurimas
6 years, 11 months ago (2014-01-25 21:10:36 UTC) #1
Lei Zhang
lgtm IDS_PRINT_PREVIEW_INVALID_PRINTER_SETTINGS probably should be renamed since it is no longer print preview only.
6 years, 11 months ago (2014-01-26 22:02:06 UTC) #2
aurimas (slooooooooow)
boliu@chromium.org: Please review changes in android_webview/*
6 years, 11 months ago (2014-01-27 17:48:33 UTC) #3
boliu
cc sgurun fyi lgtm Hmm, didn't know webview includes chrome grd resources...
6 years, 11 months ago (2014-01-27 17:55:16 UTC) #4
sgurun-gerrit only
On 2014/01/27 17:55:16, boliu wrote: > cc sgurun fyi > > lgtm > > Hmm, ...
6 years, 11 months ago (2014-01-27 17:59:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/146963004/70001
6 years, 11 months ago (2014-01-27 18:03:03 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-27 21:07:58 UTC) #7
Message was sent while issue was closed.
Change committed as 247291

Powered by Google App Engine
This is Rietveld 408576698