Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1469543003: Disable non-standard Promise functions in staging (Closed)

Created:
5 years, 1 month ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
rossberg
CC:
Michael Hablich, v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable non-standard Promise functions in staging This patch removes Promise functions and methods which are absent from the ES2015 specification when the --es-staging flag is on. BUG=v8:3237 R=rossberg LOG=Y Committed: https://crrev.com/941251af7e04d50ac2243da2870249a42111221a Cr-Commit-Position: refs/heads/master@{#32194}

Patch Set 1 #

Patch Set 2 : Fix it so it almost works #

Patch Set 3 : fix BUILD.gn #

Patch Set 4 : Fix brokenness; pass flag in tests #

Patch Set 5 : Add back removed line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -24 lines) Patch
M BUILD.gn View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 5 chunks +6 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/prologue.js View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/js/promise.js View 1 2 3 3 chunks +10 lines, -4 lines 0 comments Download
A src/js/promise-extra.js View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reentry.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-after-resolve.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-all.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-late.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-uncaught.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-all.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-throw-in-reject.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-all.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-late.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-uncaught.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-all.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/promise-internal-setter.js View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/promises.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-cr372788.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469543003/1
5 years, 1 month ago (2015-11-21 00:40:16 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/6978) v8_linux_mipsel_compile_rel on ...
5 years, 1 month ago (2015-11-21 00:42:27 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469543003/20001
5 years, 1 month ago (2015-11-21 04:15:28 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469543003/40001
5 years, 1 month ago (2015-11-21 04:20:46 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/10375)
5 years, 1 month ago (2015-11-21 04:30:46 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469543003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469543003/60001
5 years ago (2015-11-23 22:35:28 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8008)
5 years ago (2015-11-23 22:37:57 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469543003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469543003/80001
5 years ago (2015-11-23 22:41:28 UTC) #16
Dan Ehrenberg
5 years ago (2015-11-23 22:58:43 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-23 23:07:43 UTC) #19
rossberg
lgtm
5 years ago (2015-11-24 08:01:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469543003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469543003/80001
5 years ago (2015-11-24 08:50:22 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-11-24 08:51:53 UTC) #23
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/941251af7e04d50ac2243da2870249a42111221a Cr-Commit-Position: refs/heads/master@{#32194}
5 years ago (2015-11-24 08:52:00 UTC) #24
Michael Achenbach
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1473603002/ by machenbach@chromium.org. ...
5 years ago (2015-11-24 10:57:25 UTC) #25
Dan Ehrenberg
5 years ago (2015-11-24 16:00:54 UTC) #26
Message was sent while issue was closed.
On 2015/11/24 at 10:57:25, machenbach wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1473603002/ by machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] This breaks ignition on arm sim debug:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20si...
> 
> Seems to not be caught by the cq bot that builds release with dchecks..

Are you sure this was due to my change? Those failures seem to be crashes in
code which does not use promises. Did reverting the pafch fix the ignition tree?

Powered by Google App Engine
This is Rietveld 408576698