Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3263)

Unified Diff: blimp/common/proto/blimp_message.proto

Issue 1469503002: Add UNKNOWN values to blimp proto enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/common/proto/control.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/proto/blimp_message.proto
diff --git a/blimp/common/proto/blimp_message.proto b/blimp/common/proto/blimp_message.proto
index e81c608f09633d6128cb752d01ea213d6f93863d..9b1168419a7267296fb003a0e4bf531d1e483ea2 100644
--- a/blimp/common/proto/blimp_message.proto
+++ b/blimp/common/proto/blimp_message.proto
@@ -33,10 +33,11 @@ package blimp;
message BlimpMessage {
enum Type {
- COMPOSITOR = 0;
- INPUT = 1;
- CONTROL = 2;
- NAVIGATION = 3;
+ UNKNOWN = 0;
maniscalco 2015/11/20 22:33:48 Breaking the cardinal rule here, but I believe it'
Wez 2015/11/20 23:33:39 Agreed; we are OK w/ breaking changes to the proto
maniscalco 2015/11/20 23:42:21 The convention I'm familiar with is to use UNKNOWN
+ COMPOSITOR = 1;
+ INPUT = 2;
+ CONTROL = 3;
+ NAVIGATION = 4;
}
// Identifies the feature type of this message.
// The feature-specific contents are contained in optional fields of the same
« no previous file with comments | « no previous file | blimp/common/proto/control.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698