Guard Ash code with USE_ASH in chrome/browser/lifetime/

Guard Ash code with USE_ASH in chrome/browser/lifetime/

This is to allow compiling Chrome for Android with use_aura=1.

BUG=507792
Committed: https://crrev.com/1cd57962532ccb2036655478a1ee1f4f9aea797c
Cr-Commit-Position: refs/heads/master@{#361047}

[mohsen, 2015-11-20 20:29:37]

mohsen@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[mohsen, 2015-11-20 20:29:37]

Please take a look...

[mfomitchev, 2015-11-20 21:27:59]

LGTM

[mohsen, 2015-11-20 21:30:52]

mohsen@chromium.org changed reviewers:
+ sky@chromium.org

[mohsen, 2015-11-20 21:30:52]

sky@: Can you please take a look...

[sky, 2015-11-20 23:46:41]

LGTM

https://codereview.chromium.org/1469443002/diff/1/chrome/browser/lifetime/app...
File chrome/browser/lifetime/application_lifetime_aura.cc (right):

https://codereview.chromium.org/1469443002/diff/1/chrome/browser/lifetime/app...
chrome/browser/lifetime/application_lifetime_aura.cc:51: #endif  //
defined(OS_CHROMEOS)
IMO this style of comments are a waste.

[mohsen, 2015-11-21 01:05:17]

https://codereview.chromium.org/1469443002/diff/1/chrome/browser/lifetime/app...
File chrome/browser/lifetime/application_lifetime_aura.cc (right):

https://codereview.chromium.org/1469443002/diff/1/chrome/browser/lifetime/app...
chrome/browser/lifetime/application_lifetime_aura.cc:51: #endif  //
defined(OS_CHROMEOS)
On 2015/11/20 23:46:40, sky wrote:
> IMO this style of comments are a waste.

Do you mean the whole comment or just the part I added? If the former, that
definitely makes sense in cases like here where the block is small.

[sky, 2015-11-22 16:00:22]

https://codereview.chromium.org/1469443002/diff/1/chrome/browser/lifetime/app...
File chrome/browser/lifetime/application_lifetime_aura.cc (right):

https://codereview.chromium.org/1469443002/diff/1/chrome/browser/lifetime/app...
chrome/browser/lifetime/application_lifetime_aura.cc:51: #endif  //
defined(OS_CHROMEOS)
On 2015/11/21 01:05:17, mohsen wrote:
> On 2015/11/20 23:46:40, sky wrote:
> > IMO this style of comments are a waste.
> 
> Do you mean the whole comment or just the part I added? If the former, that
> definitely makes sense in cases like here where the block is small.

I mean the trailing // defined(OS_CHROMEOS). Comments like that are useful for
ifdefs spanning a large number of lines, or when there are lots of nested
ifdefs, but that isn't the case here. The style guide doesn't comment one way or
the other on this, so I leave the decision to you.

[mohsen, 2015-11-22 19:22:41]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2015-11-22 19:22:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mfomitchev@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1469443002/#ps20001
(title: "Removed unnecessary comments")

[commit-bot: I haz the power, 2015-11-22 19:22:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469443002/20001

[commit-bot: I haz the power, 2015-11-22 20:19:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-22 20:30:14]

Patchset 2 (id:??) landed as
https://crrev.com/1cd57962532ccb2036655478a1ee1f4f9aea797c
Cr-Commit-Position: refs/heads/master@{#361047}