Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 1469433002: Add LayoutTests/FlagExpectations directory for flag-specific expectations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index 5c6760114480575cf1a1e4dc05426b2c00c47d19..e8b2639b6b93c80961f85559dffc99bad4482bec 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -1295,6 +1295,10 @@ class Port(object):
paths.append(self._filesystem.join(self.layout_tests_dir(), 'SlowTests'))
return paths
+ def _flag_specific_expectations_files(self):
+ return [self._filesystem.join(self.layout_tests_dir(), 'FlagExpectations', flag.lstrip('-'))
+ for flag in self.get_option('additional_driver_flag', [])]
+
def expectations_dict(self):
"""Returns an OrderedDict of name -> expectations strings.
The names are expected to be (but not required to be) paths in the filesystem.
@@ -1342,7 +1346,9 @@ class Port(object):
return {}
def expectations_files(self):
- return [self.path_to_generic_test_expectations_file()] + self._port_specific_expectations_files()
+ return ([self.path_to_generic_test_expectations_file()] +
+ self._port_specific_expectations_files() +
+ self._flag_specific_expectations_files())
def repository_path(self):
"""Returns the repository path for the chromium code base."""

Powered by Google App Engine
This is Rietveld 408576698